Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor OC\Server::getAppFetcher #40111

Merged

Conversation

summersab
Copy link
Contributor

This PR refactors the deprecated method OC\Server::getAppFetcher and replaces it with OC\Server::get(\OC\App\AppStore\Fetcher\AppFetcher::class) throughout the entire NC codebase (excluding ./apps and ./3rdparty).

Additionally, where necessary, the \OC\App\AppStore\Fetcher\AppFetcher class is imported via the use directive.

@summersab summersab marked this pull request as ready for review August 30, 2023 01:21
@summersab summersab force-pushed the refactor/OC-Server-getAppFetcher branch 2 times, most recently from 49b8245 to db4404b Compare August 30, 2023 02:26
@solracsf solracsf added the 3. to review Waiting for reviews label Aug 30, 2023
@solracsf solracsf added this to the Nextcloud 28 milestone Aug 30, 2023
@summersab
Copy link
Contributor Author

So, I've never gotten this close to having a PR accepted by the NC team. I see everything is approved and passed, but I need to rebase. If I rebase, does that restart the approval process?

@kesselb
Copy link
Contributor

kesselb commented Aug 30, 2023

I don't think we need a rebase yet, as this branch is not much behind master.

The failure of cypress seems related to forks. I've seen the same one at #39243 and could not fix it.

@summersab
Copy link
Contributor Author

I don't think we need a rebase yet, as this branch is not much behind master.

The failure of cypress seems related to forks. I've seen the same one at #39243 and could not fix it.

Well, I promised nickvergessen that I wouldn't make any new PRs or push code for the rest of the week, so I'll hold off on doing anything until I'm told. :-)

@summersab
Copy link
Contributor Author

If I convert to draft, will that prevent CI from being triggered if I push updates?

@kesselb
Copy link
Contributor

kesselb commented Aug 30, 2023

Don't know, sorry.

@summersab
Copy link
Contributor Author

Thanks. I know that I became rather well-known in the past 24 hours, so I'd like to do what I can to prevent my newfound popularity from growing any further...

@skjnldsv skjnldsv mentioned this pull request Nov 1, 2023
This was referenced Nov 6, 2023
This was referenced Nov 14, 2023
@blizzz blizzz modified the milestones: Nextcloud 28, Nextcloud 29 Nov 23, 2023
@skjnldsv skjnldsv force-pushed the refactor/OC-Server-getAppFetcher branch from db4404b to f461c79 Compare February 23, 2024 14:43
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 23, 2024
@skjnldsv skjnldsv merged commit 0348ad5 into nextcloud:master Feb 23, 2024
150 of 158 checks passed
@blizzz blizzz mentioned this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants