Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor OC\Server::getCapabilitiesManager #40115

Merged

Conversation

summersab
Copy link
Contributor

This PR refactors the deprecated method OC\Server::getCapabilitiesManager and replaces it with OC\Server::get(\OC\CapabilitiesManager::class) throughout the entire NC codebase (excluding ./apps and ./3rdparty).

Additionally, where necessary, the \OC\CapabilitiesManager class is imported via the use directive.

@summersab summersab force-pushed the refactor/OC-Server-getCapabilitiesManager branch 2 times, most recently from 2356f1b to a2dfdbb Compare August 30, 2023 02:28
@solracsf solracsf added the 3. to review Waiting for reviews label Aug 30, 2023
@solracsf solracsf added this to the Nextcloud 28 milestone Aug 30, 2023
@skjnldsv skjnldsv mentioned this pull request Nov 1, 2023
This was referenced Nov 6, 2023
This was referenced Nov 14, 2023
@blizzz blizzz modified the milestones: Nextcloud 28, Nextcloud 29 Nov 23, 2023
This was referenced Mar 12, 2024
@skjnldsv skjnldsv requested review from Altahrim, a team, ArtificialOwl and Fenn-CS and removed request for a team March 15, 2024 12:05
@skjnldsv skjnldsv force-pushed the refactor/OC-Server-getCapabilitiesManager branch from a2dfdbb to b45c3a0 Compare March 15, 2024 12:05
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 15, 2024
Signed-off-by: John Molakvoæ <[email protected]>
@skjnldsv skjnldsv merged commit f341c21 into nextcloud:master Mar 15, 2024
156 of 165 checks passed
@Altahrim Altahrim mentioned this pull request Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants