Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[27] Saved ticket support for kerberos #40568

Draft
wants to merge 5 commits into
base: stable27
Choose a base branch
from
Draft

[27] Saved ticket support for kerberos #40568

wants to merge 5 commits into from

Conversation

icewind1991
Copy link
Member

Backport of #40165

github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 21, 2023
View reviewed changes
apps/files_external/lib/Lib/Auth/SMB/KerberosSsoSession.php
use OCP\IL10N;
use OCP\ISession;

class KerberosSsoSession extends AuthMechanism {

Check notice

Code scanning / Psalm

PropertyNotSetInConstructor Note

Property OCA\Files_External\Lib\Auth\SMB\KerberosSsoSession::$scheme is not defined in constructor of OCA\Files_External\Lib\Auth\SMB\KerberosSsoSession or in any private or final methods called in the constructor
apps/files_external/lib/Lib/Auth/SMB/KerberosSsoDatabase.php
use OCP\IUser;
use OCP\Security\ICredentialsManager;

class KerberosSsoDatabase extends AuthMechanism {

Check notice

Code scanning / Psalm

PropertyNotSetInConstructor Note

Property OCA\Files_External\Lib\Auth\SMB\KerberosSsoDatabase::$scheme is not defined in constructor of OCA\Files_External\Lib\Auth\SMB\KerberosSsoDatabase or in any private or final methods called in the constructor
@icewind1991 icewind1991 force-pushed the kerberos-saved-ticket-27 branch 6 times, most recently from 32af94e to 884d3de Compare October 24, 2023 14:23
@solracsf solracsf added this to the Nextcloud 27.1.5 milestone Nov 21, 2023
@blizzz blizzz mentioned this pull request Dec 4, 2023
Merged
@blizzz
Copy link
Member

blizzz commented Dec 7, 2023

moving to 27.1.6

@blizzz blizzz mentioned this pull request Jan 15, 2024
Merged
@blizzz
Copy link
Member

blizzz commented Jan 15, 2024

@icewind1991 it's still in draft state – what's the outlook?

@blizzz
Copy link
Member

blizzz commented Jan 18, 2024

moving to 27.1.7

@solracsf solracsf added the 2. developing Work in progress label Jan 19, 2024
This was referenced Feb 9, 2024
Closed
Merged
This was referenced Feb 20, 2024
Closed
Merged
@Altahrim Altahrim mentioned this pull request Mar 21, 2024
Merged
5 tasks
@blizzz blizzz removed this from the Nextcloud 27.1.11 milestone Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2. developing Work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@icewind1991 @blizzz @Altahrim @solracsf @skjnldsv