Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dav: fix wrong decoding of pluses in URLs #40594

Merged
merged 1 commit into from
Jan 31, 2024
Merged

dav: fix wrong decoding of pluses in URLs #40594

merged 1 commit into from
Jan 31, 2024

Commits on Jan 31, 2024

  1. dav: fix wrong decoding of pluses in URLs 

    PHP's urldecode function does not decode URLs according to RFC 3986, but
according to the HTML 4.01 query parameter
encoding. This results in pluses being wrongly decoded to spaces even
though they should not be decoded at all.

Use rawurldecode instead, which follows RFC 3986 properly.

This fixes an issue where files on DAV shares containing pluses were
incorrectly decoded to spaces.

Fixes: nextcloud#15849
Signed-off-by: Lorenz Brun <[email protected]>
    @lorenz @skjnldsv
    lorenz authored and skjnldsv committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    a6f879e View commit details
    Browse the repository at this point in the history