Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Unify running a dev server (for automated testing) #40899

Merged
merged 1 commit into from
Nov 2, 2023
Merged

refactor: Unify running a dev server (for automated testing) #40899

merged 1 commit into from
Nov 2, 2023

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Oct 13, 2023 •
edited
Loading

Summary

Makes it quite easy to spin up a dev web server:

composer serve

It's possible to influence hostname, port and number of worker processes:

NEXTCLOUD_HOST=127.0.0.1 NEXTCLOUD_PORT=8081 NEXTCLOUD_WORKERS=10 composer serve

Ref https://github.com/php-pds/composer-script-names_research for the naming convention.

TODO

  • Add new composer script
  • Set PHP_CLI_SERVER_WORKERS and make it overridable to have a bit of concurrency

Checklist

@ChristophWurst ChristophWurst added the 2. developing Work in progress label Oct 13, 2023
@ChristophWurst ChristophWurst self-assigned this Oct 13, 2023
@ChristophWurst

This comment was marked as outdated.

Sign in to view
@ChristophWurst ChristophWurst force-pushed the refactor/unify-running-dev-server branch from 70575db to 22e669a Compare October 13, 2023 12:19
@solracsf solracsf added this to the Nextcloud 28 milestone Oct 27, 2023
@ChristophWurst ChristophWurst added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Oct 31, 2023
@ChristophWurst ChristophWurst marked this pull request as ready for review October 31, 2023 17:03
@skjnldsv skjnldsv mentioned this pull request Nov 1, 2023
Merged
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 2, 2023
@ChristophWurst ChristophWurst force-pushed the refactor/unify-running-dev-server branch from 0abdbf8 to 074827c Compare November 2, 2023 07:41
@ChristophWurst ChristophWurst added the pending documentation This pull request needs an associated documentation update label Nov 2, 2023
Altahrim
Altahrim reviewed Nov 2, 2023
View reviewed changes
composer.json Outdated Show resolved Hide resolved
@ChristophWurst ChristophWurst added 3. to review Waiting for reviews and removed 4. to release Ready to be released and/or waiting for tests to finish labels Nov 2, 2023
@ChristophWurst ChristophWurst force-pushed the refactor/unify-running-dev-server branch from 88ad66c to 0da4c14 Compare November 2, 2023 08:59
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 2, 2023
@ChristophWurst ChristophWurst merged commit 7c66189 into master Nov 2, 2023
50 checks passed
@ChristophWurst ChristophWurst deleted the refactor/unify-running-dev-server branch November 2, 2023 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Altahrim Altahrim Altahrim approved these changes

@provokateurin provokateurin provokateurin approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@juliushaertl juliushaertl Awaiting requested review from juliushaertl

@solracsf solracsf Awaiting requested review from solracsf

Assignees

@ChristophWurst ChristophWurst

Labels
4. to release Ready to be released and/or waiting for tests to finish pending documentation This pull request needs an associated documentation update
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.
5 participants
@ChristophWurst @Altahrim @skjnldsv @provokateurin @solracsf