Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(files): fix default sorting direction #41330

Closed
wants to merge 2 commits into from
Closed

fix(files): fix default sorting direction #41330

wants to merge 2 commits into from

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Nov 7, 2023

Summary

On NEW users, the sorting config doesn't exist in the backend.
The default to basename is set in the front, but not the default direction

@skjnldsv skjnldsv added this to the Nextcloud 28 milestone Nov 7, 2023
@skjnldsv skjnldsv requested a review from a team November 7, 2023 15:56
@skjnldsv skjnldsv self-assigned this Nov 7, 2023
@skjnldsv skjnldsv requested review from artonge, Fenn-CS, sorbaugh and susnux and removed request for a team November 7, 2023 15:56
@blizzz blizzz mentioned this pull request Nov 8, 2023
Merged
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 9, 2023
This was referenced Nov 10, 2023
Merged
Merged
@blizzz blizzz mentioned this pull request Nov 20, 2023
Merged
5 tasks
@blizzz
Copy link
Member

blizzz commented Nov 22, 2023

/compile amend /

@susnux @nextcloud-command
chore: Compile assets
64b2d0a 
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
@susnux
Copy link
Contributor

susnux commented Nov 22, 2023 •
edited
Loading

This was already fixed by @nickvergessen in #41485

@susnux susnux closed this Nov 22, 2023
@susnux susnux deleted the fix/files/default-sorting branch November 22, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@artonge artonge artonge approved these changes

@Fenn-CS Fenn-CS Awaiting requested review from Fenn-CS Fenn-CS was automatically assigned from nextcloud/server-frontend

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh was automatically assigned from nextcloud/server-frontend

Assignees

@skjnldsv skjnldsv

Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: files
Projects
Files to vue
Status: Done
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.
4 participants
@skjnldsv @blizzz @susnux @artonge