-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(files): make files list valid table layout #41577
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShGKme
added
2. developing
Work in progress
feature: files
accessibility
files2vue
labels
Nov 17, 2023
ShGKme
requested review from
artonge,
skjnldsv,
pulsejet,
susnux,
JuliaKirschenheuter,
Pytal and
szaimen
November 17, 2023 15:19
Still a draft because I'm testing to check if I'm sure that the virtual scrolling is not broken. But ready for review |
JuliaKirschenheuter
approved these changes
Nov 17, 2023
Pytal
approved these changes
Nov 17, 2023
susnux
approved these changes
Nov 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM at least the "before"-action will be fixed :)
ShGKme
force-pushed
the
fix/41568/files-list--valid-table-layout
branch
from
November 17, 2023 22:35
e505416
to
1781c94
Compare
Otherwise it is not valid and does not ception the table. Signed-off-by: Grigorii K. Shartsev <[email protected]>
<div> is not allowed as a <table> child Signed-off-by: Grigorii K. Shartsev <[email protected]>
ShGKme
force-pushed
the
fix/41568/files-list--valid-table-layout
branch
from
November 17, 2023 23:16
1781c94
to
346c617
Compare
@skjnldsv Sorry for the fast merge, we needed it in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
<caption>
must be a direct child of<table>
, otherwise it doesn't work#before
content<div>
for a#before
is not allowed as a child of<table>
;
)::deep
with:deep()
Screenshots
Recording.2023-11-17.233217.mp4
Checklist