Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(files): navigation exact #42095

Merged
merged 2 commits into from
Dec 13, 2023
Merged

fix(files): navigation exact #42095

merged 2 commits into from
Dec 13, 2023

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Dec 7, 2023

Fix #41737

@skjnldsv skjnldsv requested review from a team, Fenn-CS, sorbaugh and emoral435 and removed request for a team December 7, 2023 11:28
@skjnldsv skjnldsv self-assigned this Dec 7, 2023
@skjnldsv skjnldsv added this to the Nextcloud 29 milestone Dec 7, 2023
@skjnldsv
Copy link
Member Author

skjnldsv commented Dec 7, 2023

/backport to stable28

@szaimen
Copy link
Contributor

szaimen commented Dec 10, 2023

Can you please post a screenshot of before and after?

@skjnldsv
Copy link
Member Author

Can you please post a screenshot of before and after?

It's straightforward, no need for a screenshot. Before the parent and children gets the active display, after only the selected children get the focus.

See linked issue:
image

szaimen
szaimen approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM then :)

emoral435
emoral435 approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@emoral435 emoral435 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it on my dev setup and it works 👍 LGTM as well!

@skjnldsv @emoral435
fix(files): navigation exact
fb39015 
Signed-off-by: John Molakvoæ <[email protected]>
@emoral435
Copy link
Contributor

/compile /

@nextcloud-command
chore(assets): Recompile assets
7fe9d3a 
Signed-off-by: nextcloud-command <[email protected]>
@jancborchardt jancborchardt mentioned this pull request Dec 13, 2023
Closed
@emoral435 emoral435 merged commit d6ac1b9 into master Dec 13, 2023
42 checks passed
@emoral435 emoral435 deleted the fix/files/exact-nav branch December 13, 2023 15:28
@szaimen
Copy link
Contributor

szaimen commented Dec 13, 2023

/backport fb39015 to stable28

1 similar comment
@AndyScherzinger
Copy link
Member

/backport fb39015 to stable28

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Dec 14, 2023
Merged
@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@szaimen szaimen szaimen approved these changes

@emoral435 emoral435 emoral435 approved these changes

@Fenn-CS Fenn-CS Awaiting requested review from Fenn-CS Fenn-CS was automatically assigned from nextcloud/server-frontend

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh was automatically assigned from nextcloud/server-frontend

Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews bug feature: files
Projects
None yet
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.

Multiple highlighted / active elements in left sidebar for favorites
5 participants
@skjnldsv @szaimen @emoral435 @AndyScherzinger @nextcloud-command