Clean-up and standardization of "App password" #42109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
approved these changes
Dec 13, 2023
susnux
requested review from
a team,
Fenn-CS,
szaimen,
emoral435 and
juliushaertl
and removed request for
a team and
emoral435
susnux
added
3. to review
Fenn-CS
reviewed
Dec 13, 2023
How to do this using the GitHub web UI? |
Oh, in that case, I would just squash or recommend that anyone who does squashes before merge. While the changes look okay, I do not know anything about this word alignment so I would tag @AndyScherzinger and once he gives a green light, we would get this in. Thanks for the pr @rakekniven (no action required from your end) |
juliushaertl
approved these changes
Dec 15, 2023
Signed-off-by: rakekniven <[email protected]>
juliushaertl
force-pushed
the
rakekniven-patch-4
branch
from
30fd4fd
to
4ff2c08
Compare
|
Squashed the commits into one since squash-merge is disabled here |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported at Transifex.
We have only two occurences at Transifex matching "App token".
We have 21 matching "App password".
After looking at the UI, code and discussion at community chat I propose to align the wording.