enh(dashboard): changed h1 to say Dashboard instead of Nextcloud #42381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emoral435
requested review from
susnux,
JuliaKirschenheuter,
Pytal and
ShGKme
|
/backport to stable28 |
ShGKme
approved these changes
Dec 19, 2023
ShGKme
requested changes
Dec 19, 2023
emoral435
force-pushed
the
fix/h1-element-rename-for-dashboard
branch
from
8798165
to
4d51a99
Compare
ShGKme
approved these changes
Dec 19, 2023
susnux
approved these changes
Dec 19, 2023
emoral435
force-pushed
the
fix/h1-element-rename-for-dashboard
branch
3 times, most recently
from
99e1a14
to
9f4e70d
Compare
Signed-off-by: Eduardo Morales <[email protected]>
Signed-off-by: Eduardo Morales <[email protected]>
emoral435
force-pushed
the
fix/h1-element-rename-for-dashboard
branch
from
9f4e70d
to
be54715
Compare
|
A regression: it also changes the |
Ah, so complete honesty - I do not know how Nextcloud handles regressions like this. Should we open a new issue for this? And if its not too big, where is the title being affect? Maybe I can take a look at it :) @ShGKme |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves #42267
🖼️ Screenshots
🏚️ Before
🏡 After
🚧 Summary
In order to make the dashboard / main page more accessible, the heading will be changed to something more descriptive, such as 'Dashboard'. I checked out the rest of the dashboard controller, and there seemed to be no usage of the translator, but if there is, it is preferable to use it here in this change for the header.
Checklist