fix(dav): Hide less than minute diff in calendar notification title #42406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jld3103 <[email protected]>
provokateurin
added
bug
3. to review
provokateurin
requested review from
ChristophWurst,
miaulalala and
tcitworld
as code owners
|
/backport to stable28 |
ChristophWurst
approved these changes
Dec 20, 2023
miaulalala
approved these changes
Dec 20, 2023
miaulalala
deleted the
fix/dav/calendar-notification-less-than-minute-title
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This has been bugging me for a long time, now I'll fix it as a christmas gift for myself :D
If you check the notifications at the moment when the event starts the diff is less than a minute. In that case the notification title will be
... (in )or... ( ago). Please let me know if there is a better way to detect if the diff is less than a minute.Checklist