Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(files_external): add back js config files #42428

Merged
merged 1 commit into from
Jan 6, 2024
Merged

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Dec 21, 2023

Seems I cleaned up too much in 38480fd
The settings still have their own legacy handlings

/**
* @return string[]
*/
public function getCustomJs(): array {
return $this->customJs;
}
/**
* @param string $custom
* @return self
*/
public function addCustomJs(string $custom): self {
$this->customJs[] = $custom;
return $this;
}



Fix #42158

@skjnldsv skjnldsv added this to the Nextcloud 29 milestone Dec 21, 2023
@skjnldsv skjnldsv self-assigned this Dec 21, 2023
@skjnldsv skjnldsv requested review from a team, ArtificialOwl, icewind1991 and sorbaugh and removed request for a team December 21, 2023 16:47
@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Dec 21, 2023
@skjnldsv skjnldsv requested review from a team, Fenn-CS and emoral435 and removed request for ArtificialOwl and a team December 21, 2023 16:47
@skjnldsv
Copy link
Member Author

/backport to stable28

Copy link
Contributor

@emoral435 emoral435 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I see what happened! LGTM!

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@szaimen szaimen enabled auto-merge January 6, 2024 09:25
@szaimen szaimen merged commit 9416778 into master Jan 6, 2024
53 of 54 checks passed
@szaimen szaimen deleted the fix/external-js branch January 6, 2024 09:38
@blizzz blizzz mentioned this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Could not find resource files_external/js/public_key.js to load
3 participants