Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Nc Vue to 8.4.0 #42499

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Update Nc Vue to 8.4.0 #42499

merged 1 commit into from
Jan 2, 2024

Conversation

JuliaKirschenheuter
Copy link
Contributor

@JuliaKirschenheuter
Copy link
Contributor Author

/compile amend /

@susnux
Copy link
Contributor

susnux commented Dec 27, 2023

@JuliaKirschenheuter you need to update the snapshots when updating nextcloud-vue.
Should work with npm run test -- --updateSnapshot or something like this

@JuliaKirschenheuter
Copy link
Contributor Author

Thank you @susnux!

Unfortunately i've got 50 failed tests ;( what should i do to fix it?

@skjnldsv
Copy link
Member

/compile

Signed-off-by: julia.kirschenheuter <[email protected]>
@ShGKme
Copy link
Contributor

ShGKme commented Jan 2, 2024

To update snapshots:

npm run test:coverage -- -u
# same as
npm run test:coverage -- --updateSnapshot

-- here is used to pass options/arguments not to npm run command, but to the command it runs (jest --coverage).

Or fast version to skip coverage - directly run Jest:

npx jest -u

Unfortunately i've got 50 failed tests ;( what should i do to fix it?

It happens when there are additional apps in app directory, e.g. activity, photos, text, viewer. Jest doesn't respect .gitignore and runs tests and __mocks__ from extra apps.

@JuliaKirschenheuter JuliaKirschenheuter merged commit 7ac9031 into master Jan 2, 2024
42 checks passed
@JuliaKirschenheuter JuliaKirschenheuter deleted the bump-nc-vue-to-8.4.0 branch January 2, 2024 10:42
@blizzz blizzz mentioned this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants