Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh(core): replaced previous native a element with NcButton #42636

Merged

Conversation

emoral435
Copy link
Contributor

Summary

Replaces native element with the NcButton primary button, that works with contrast, defines the role of the element as role="button", keeps the same logic, and added the <img/> elements alt attribute.

Once this passes all reviews, I will remove all the commented out code unless you guys wish to leave it there :)

🖼️ Screenshots

🏚️ Before 🏡 After
firefox_P7wrQ33Da0 firefox_EloQYE2bqV

Checklist

@emoral435 emoral435 added 3. to review Waiting for reviews feature: profile PRs or issues related to the Profile feature (e.g. Profile page, API, etc.) accessibility labels Jan 8, 2024
@emoral435 emoral435 self-assigned this Jan 8, 2024
core/src/components/Profile/PrimaryActionButton.vue Outdated Show resolved Hide resolved
core/src/components/Profile/PrimaryActionButton.vue Outdated Show resolved Hide resolved
core/src/components/Profile/PrimaryActionButton.vue Outdated Show resolved Hide resolved
core/src/components/Profile/PrimaryActionButton.vue Outdated Show resolved Hide resolved
@emoral435 emoral435 force-pushed the fix/core/42596/fix-button-accessibility-in-view-profile-page branch from 3a83f25 to a2c311f Compare January 8, 2024 20:22
@emoral435 emoral435 requested a review from ShGKme January 8, 2024 20:24
@emoral435 emoral435 force-pushed the fix/core/42596/fix-button-accessibility-in-view-profile-page branch from a2c311f to d8c9e5f Compare January 8, 2024 20:29
@emoral435 emoral435 force-pushed the fix/core/42596/fix-button-accessibility-in-view-profile-page branch from d8c9e5f to 6aebb04 Compare January 9, 2024 00:24
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks fine now, thank you for the changes.

Don't forget to remove the commented lines :p

@szaimen szaimen removed their request for review January 9, 2024 13:07
@emoral435 emoral435 force-pushed the fix/core/42596/fix-button-accessibility-in-view-profile-page branch from 6aebb04 to 5128daf Compare January 9, 2024 14:05
@emoral435
Copy link
Contributor Author

Gotcha! Will remove the comments now that you have cleared it :) Also dont mind the cherry pick, that was a mistake!

@emoral435 emoral435 force-pushed the fix/core/42596/fix-button-accessibility-in-view-profile-page branch from 5128daf to f7ba102 Compare January 9, 2024 14:06
@emoral435 emoral435 force-pushed the fix/core/42596/fix-button-accessibility-in-view-profile-page branch from f7ba102 to b01377d Compare January 9, 2024 14:33
@emoral435
Copy link
Contributor Author

/backport to stable28

@emoral435 emoral435 force-pushed the fix/core/42596/fix-button-accessibility-in-view-profile-page branch from b01377d to c571387 Compare January 9, 2024 14:46
@emoral435 emoral435 requested a review from susnux January 9, 2024 16:32
@emoral435 emoral435 force-pushed the fix/core/42596/fix-button-accessibility-in-view-profile-page branch from c571387 to 707c1c0 Compare January 9, 2024 16:33
@susnux susnux merged commit 6daa77b into master Jan 9, 2024
41 checks passed
@susnux susnux deleted the fix/core/42596/fix-button-accessibility-in-view-profile-page branch January 9, 2024 18:43
@backportbot-nextcloud
Copy link

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b fix/foo-stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable28

Error: Unknown error

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews accessibility feature: profile PRs or issues related to the Profile feature (e.g. Profile page, API, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BITV]: Replace link with NcButton
4 participants