Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(openapi): Make OpenAPI CI green again #42705

Merged
merged 1 commit into from
Jan 11, 2024
Merged

fix(openapi): Make OpenAPI CI green again #42705

merged 1 commit into from
Jan 11, 2024

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen added the 3. to review Waiting for reviews label Jan 11, 2024
@nickvergessen nickvergessen added this to the Nextcloud 29 milestone Jan 11, 2024
@nickvergessen nickvergessen self-assigned this Jan 11, 2024
@nickvergessen nickvergessen mentioned this pull request Jan 11, 2024
Merged
4 tasks
susnux
susnux approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, but then we should not recommend everyone to use the new way 😶

github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 11, 2024
View reviewed changes
core/Controller/ProfilePageController.php
@@ -42,7 +42,7 @@
use OCP\Share\IManager as IShareManager;
use OCP\UserStatus\IManager as IUserStatusManager;

#[OpenAPI(scope: OpenAPI::SCOPE_IGNORE)]
#[IgnoreOpenAPI]

Check notice

Code scanning / Psalm

DeprecatedClass Note

OCP\AppFramework\Http\Attribute\IgnoreOpenAPI is marked deprecated
@szaimen
Copy link
Contributor

szaimen commented Jan 11, 2024

Makes openAPI green 👍

@szaimen szaimen merged commit 67fba0a into master Jan 11, 2024
47 of 49 checks passed
@szaimen szaimen deleted the bugfix/noid/green-openapi-ci branch January 11, 2024 11:55
@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@juliushaertl juliushaertl juliushaertl approved these changes

@bigcat88 bigcat88 bigcat88 approved these changes

@provokateurin provokateurin Awaiting requested review from provokateurin

@come-nc come-nc Awaiting requested review from come-nc

@emoral435 emoral435 Awaiting requested review from emoral435

Assignees

@nickvergessen nickvergessen

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.
5 participants
@nickvergessen @szaimen @susnux @juliushaertl @bigcat88