make failure to load app commands non-fatal #42811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
requested review from
a team,
ArtificialOwl,
blizzz and
Fenn-CS
and removed request for
a team
blizzz
approved these changes
Jan 15, 2024
icewind1991
force-pushed
the
app-command-load-non-fatal
branch
from
ff5caf0
to
7648b7a
Compare
|
/backport to stable28 |
|
/backport to stable27 |
sorbaugh
approved these changes
Feb 1, 2024
come-nc
approved these changes
Feb 1, 2024
artonge
approved these changes
Feb 1, 2024
Signed-off-by: Robin Appelman <[email protected]>
blizzz
force-pushed
the
app-command-load-non-fatal
branch
from
7648b7a
to
860caa0
Compare
blizzz
added
4. to release
This was referenced Feb 2, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if a command fails to load the occ commands fails with a fatal error. This also prevents using
occ app:disableto disable the offending command.This instead catches the error, logs it and continues loading the commands from other apps.