Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppConfig: returns default on exception #42844

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

ArtificialOwl
Copy link
Member

@ArtificialOwl ArtificialOwl commented Jan 16, 2024

catching exception from isLazy() and returns default.

should fix #42846

Signed-off-by: Maxence Lange <[email protected]>
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to solve #42846 in a quick test

@nickvergessen nickvergessen added this to the Nextcloud 29 milestone Jan 16, 2024
@nickvergessen nickvergessen added bug 3. to review Waiting for reviews regression php Pull requests that update Php code labels Jan 16, 2024
@nickvergessen nickvergessen merged commit c69be30 into master Jan 16, 2024
50 checks passed
@nickvergessen nickvergessen deleted the fix/noid/default-on-unknown-config-key branch January 16, 2024 15:21
@blizzz blizzz mentioned this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug php Pull requests that update Php code regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OCS Api to get app config value is throwing on unknown values instead of returning specified default
4 participants