Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ContactsStore: Avoid exceptions on empties #42860

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Conversation

joshtrichards
Copy link
Member

@joshtrichards joshtrichards commented Jan 17, 2024

Summary

Fixes #42858 and makes things more robust in general in this particular function

TODO

  • Confirm backporting (NC28: well, yeah, but not sure about <NC28; if so probably manual required)

Checklist

Fixes #42858 and makes things more robust

Signed-off-by: Josh <[email protected]>
@szaimen
Copy link
Contributor

szaimen commented Jan 17, 2024

Sorry, not really familiar with that part of the code

@szaimen szaimen requested review from a team, ArtificialOwl, icewind1991 and Fenn-CS and removed request for szaimen and a team January 17, 2024 16:11
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@ChristophWurst
Copy link
Member

/backport to stable28

@ChristophWurst
Copy link
Member

/backport to stable27

@ChristophWurst
Copy link
Member

/backport to stable26

@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 17, 2024
@Pytal Pytal merged commit e42f511 into master Jan 17, 2024
50 checks passed
@Pytal Pytal deleted the jr/fix/i42858 branch January 17, 2024 18:39
@backportbot-nextcloud
Copy link

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

Error: Unknown error

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@backportbot-nextcloud
Copy link

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin stable26

# Create the new backport branch
git checkout -b fix/foo-stable26

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26

Error: Unknown error

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: After upgrade to 28.0.1 nonstop errors regarding guestName avatar
4 participants