fix(db): Fix replica password example config #42890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliushaertl
approved these changes
Jan 17, 2024
joshtrichards
approved these changes
Jan 19, 2024
config/config.sample.php
Outdated
| @@ -155,8 +155,8 @@ | |||
| * Specify read only replicas to be used by Nextcloud when querying the database | |||
| */ | |||
| 'dbreplica' => [ | |||
| ['user' => 'replica1', 'password', 'host' => '', 'dbname' => ''], | |||
| ['user' => 'replica1', 'password', 'host' => '', 'dbname' => ''], | |||
| ['user' => 'replica1', 'password' => 'password1', 'host' => '', 'dbname' => ''], | |||
There was a problem hiding this comment.
Suggested change
| ['user' => 'replica1', 'password' => 'password1', 'host' => '', 'dbname' => ''], | |
| ['user' => 'nextcloud', 'password' => 'password1', 'host' => 'replica1', 'dbname' => 'nextcloud'], |
config/config.sample.php
Outdated
| ['user' => 'replica1', 'password', 'host' => '', 'dbname' => ''], | ||
| ['user' => 'replica1', 'password', 'host' => '', 'dbname' => ''], | ||
| ['user' => 'replica1', 'password' => 'password1', 'host' => '', 'dbname' => ''], | ||
| ['user' => 'replica2', 'password' => 'password2', 'host' => '', 'dbname' => ''], |
There was a problem hiding this comment.
Suggested change
| ['user' => 'replica2', 'password' => 'password2', 'host' => '', 'dbname' => ''], | |
| ['user' => 'nextcloud', 'password' => 'password2', 'host' => 'replica2', 'dbname' => 'nextcloud'], |
ChristophWurst
force-pushed
the
fix/db/replica-password-sample-config
branch
from
898c9af
to
74a7291
Compare
joshtrichards
approved these changes
Jan 22, 2024
ChristophWurst
added
4. to release
Signed-off-by: Christoph Wurst <[email protected]>
juliushaertl
force-pushed
the
fix/db/replica-password-sample-config
branch
from
74a7291
to
5dd7513
Compare
10 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replica config is an associative array with password=>password.
Ref #41998
Checklist