Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): Fix OpenAPI diff on non-default specs #42974

Merged
merged 1 commit into from
Jan 20, 2024

Conversation

provokateurin
Copy link
Member

@provokateurin provokateurin commented Jan 19, 2024

Summary

Required to also fail on diffs for specs that are not the default one.

Checklist

@provokateurin provokateurin added bug 3. to review Waiting for reviews labels Jan 19, 2024
@provokateurin provokateurin added this to the Nextcloud 29 milestone Jan 19, 2024
@provokateurin
Copy link
Member Author

/skjnldsv-backport to stable28

Copy link
Member

@bigcat88 bigcat88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Description for the PR:

Matches files that contain openapi anywhere in the name and end with .json. For example, both api-openapi.json and openapi-version2.json will match.

More flexible, allowing for additional characters in the filename before the .json extension.

@provokateurin provokateurin merged commit 6f1393d into master Jan 20, 2024
41 checks passed
@provokateurin provokateurin deleted the fix/build/openapi-diff-non-default branch January 20, 2024 07:31
@skjnldsv
Copy link
Member

/backport to stable28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants