Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] Fix npm audit #43017

Merged
merged 1 commit into from
Jan 22, 2024
Merged

[master] Fix npm audit #43017

merged 1 commit into from
Jan 22, 2024

Conversation

nextcloud-command
Copy link
Contributor

Auto-generated fix of npm audit

@szaimen szaimen added this to the Nextcloud 29 milestone Jan 22, 2024
@szaimen szaimen requested review from a team, Fenn-CS and sorbaugh and removed request for a team January 22, 2024 11:23
@ChristophWurst ChristophWurst removed their request for review January 22, 2024 11:24
@susnux
Copy link
Contributor

susnux commented Jan 22, 2024

@szaimen I think it was your PR, when you last pushed the CI succeeded, but in the meantime some styles were changed on server.
So when merging your PR overwrote the styles, and this now produces the combination from both changes 😉

Can only be prevented when forcing branches to be up-to-date with master before merging -> really a lot more CI time

@szaimen
Copy link
Contributor

szaimen commented Jan 22, 2024

I guess ci is nor checking if css files are up-to-date? It seems to check only js files...

@szaimen szaimen merged commit 4c1452f into master Jan 22, 2024
44 checks passed
@szaimen szaimen deleted the automated/noid/master-fix-npm-audit branch January 22, 2024 14:53
@blizzz blizzz mentioned this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants