Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle storage not available when expiring versions #43078

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

icewind1991
Copy link
Member

Prevents the expire from crashing when, for example, a remote share isn't available.

Since any version from a non-available storage might be named, it doesn't expire them. This might lead to some extra versions being kept around longer than needed but seems preferable over accidentally deleting a named version.

@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Jan 24, 2024
@icewind1991 icewind1991 added this to the Nextcloud 29 milestone Jan 24, 2024
@icewind1991 icewind1991 requested review from artonge, a team, ArtificialOwl and Altahrim and removed request for a team January 24, 2024 09:51
@icewind1991
Copy link
Member Author

/backport to stable28

@icewind1991
Copy link
Member Author

/backport to stable27

@icewind1991
Copy link
Member Author

/backport to stable26

@icewind1991 icewind1991 merged commit c130079 into master Jan 25, 2024
52 of 53 checks passed
@icewind1991 icewind1991 deleted the version-expire-handle-storage branch January 25, 2024 16:27
@blizzz blizzz mentioned this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants