Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(files): combine navigation and files list into single Vue app #43090

Merged
merged 2 commits into from
Jan 25, 2024

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Jan 24, 2024

Summary

During files2vue migration, files were migrated as two Vue apps:

  • Navigation = <NcAppNavitation>
  • FilesList = <NcAppContent>

But Vue app in Nextcloud is supposed to be one NcContent app that contains navigation and content.

After migration has finished there is no need to separate Navigation and FilesList.

TODO

  • Combine Navigation and FilesList into one Files App
  • Remove any custom content from PHP template for files
    • There were two hidden inputs, but they are not used anymore
  • Check that public share is still working

Screenshots

No visual changes on both user files and public share

Checklist

@ShGKme ShGKme self-assigned this Jan 24, 2024
@ShGKme ShGKme changed the title fix(files): combine navigation and files list in one Vue app fix(files): combine navigation and files list into single Vue app Jan 24, 2024
@ShGKme ShGKme added this to the Nextcloud 29 milestone Jan 24, 2024
@ShGKme ShGKme added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 24, 2024
@ShGKme ShGKme marked this pull request as ready for review January 24, 2024 21:42
@ShGKme ShGKme force-pushed the fix/files--combine-navigation-and-app branch 2 times, most recently from 2806fb0 to 3840a99 Compare January 24, 2024 22:38
@ShGKme ShGKme force-pushed the fix/files--combine-navigation-and-app branch from 3840a99 to aa18769 Compare January 24, 2024 23:26
@nickvergessen nickvergessen removed their request for review January 25, 2024 06:44
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works great, thank you!

@JuliaKirschenheuter JuliaKirschenheuter merged commit 3f0533b into master Jan 25, 2024
53 checks passed
@JuliaKirschenheuter JuliaKirschenheuter deleted the fix/files--combine-navigation-and-app branch January 25, 2024 10:10
@JuliaKirschenheuter
Copy link
Contributor

/backport b40279e to stable28

@ShGKme ShGKme mentioned this pull request Feb 23, 2024
4 tasks
@blizzz blizzz mentioned this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Leave only onemain landmark on files page
4 participants