Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): Make PostgreSQL unit tests less flacky by ordering #43099

Merged

Conversation

nickvergessen
Copy link
Member

Summary

Postgres uses a journal file, so if you select a list from DB without ordering it, the order does not have to be FIFO.
Since the test is not about ordering but selecting distinct, it's okay to change the order to configkey (there was only 1 appid selected anyway so sorting by that doesn't do anything).

Checklist

@nickvergessen
Copy link
Member Author

/backport to stable28

@nickvergessen
Copy link
Member Author

Why does this happen only now? I can only assume that before due to the 3 columns Postgres did not use a journal, but since recent additions now being 5 columns it started using it.

@nickvergessen nickvergessen merged commit 2357bcb into master Jan 25, 2024
53 checks passed
@nickvergessen nickvergessen deleted the bugfix/noid/make-postgres-unit-test-less-flacky branch January 25, 2024 18:55
@blizzz blizzz mentioned this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants