Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable28] fix: added a label element to the NcSelect in update settings #43158

Merged
merged 2 commits into from
Feb 2, 2024
Merged

[stable28] fix: added a label element to the NcSelect in update settings #43158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eea9900
fix: added a label element to the NcSelect in update settings
emoral435 Jan 24, 2024
f59ef7b
chore: compile assets
emoral435 Jan 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions apps/updatenotification/src/components/UpdateNotification.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,8 +131,9 @@
<em v-html="noteDelayedStableString" />
</p>

<h4>{{ t('updatenotification', 'Notify members of the following groups about available updates:') }}</h4>
<NcSelect v-model="notifyGroups"
id="notify-members-settings-select-wrapper"
:input-label="t('updatenotification', 'Notify members of the following groups about available updates:')"
:options="groups"
:multiple="true"
label="displayname"
Expand Down Expand Up @@ -483,9 +484,6 @@ export default {
}
}
}
h4 {
margin-block-end: 0.7rem;
}
.update-channel-selector {
display: flex;
align-items: center;
Expand Down Expand Up @@ -547,5 +545,13 @@ export default {
.update-menu .icon-star:focus {
background-image: var(--icon-starred);
}
/* override NcSelect styling so that label can have correct width */
#notify-members-settings-select-wrapper {
width: fit-content;

.vs__dropdown-toggle {
min-width: 100%;
}
}
}
</style>
Loading
Loading