Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(files): drop to folder path and user feedback #43267

Merged
merged 5 commits into from
Feb 7, 2024

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Feb 1, 2024

Please review two commits separately

Uploading: addaa9b

  • Better feedback when dragging external files and dropping them to a displayed folder
  • Fix the wrong path (currently, it takes the full dropped Folder path, but the uploader destination is always set to the current Folder. Leading uploading failures to paths like /Photos/Photos/Landscapes)
  • Fixes t.dataTransfer.files.forEach is not a function
    image

Cleanup: 23d934f

On a previous version, we were using the default CheckboxRadioSwitch model behaviour, that only works with string. With defineComponent we now see that there are a lot of typing issues. We switch back to properly using a number and not a string

FileEntry mixin: 1d46720

Much cleaner to not have duplicate code 🙈

@skjnldsv skjnldsv added this to the Nextcloud 29 milestone Feb 1, 2024
@skjnldsv skjnldsv self-assigned this Feb 1, 2024
@skjnldsv skjnldsv requested review from susnux, ShGKme, a team, Fenn-CS and sorbaugh and removed request for a team February 1, 2024 18:35
@ShGKme

This comment was marked as resolved.

@skjnldsv
Copy link
Member Author

skjnldsv commented Feb 2, 2024

I couldn't reproduce the issue from the linked comment...

Part of it has been fixed already, some remains:

Issue 1

t.dataTransfer.files.forEach is not a function

Peek.02-02-2024.08-06.mp4

Issue 2

Considering the following path: /Top folder/Sub folder
Dragging a file on Sub folder while being in the /Top folder directory leads to a wrong path being used
PUT /remote.php/dav/files/admin/Top%20folder/Top%20folder/Sub%20folder/dillon-wanner-zawKJJBGQR0-unsplash.jpg 404 (Not Found)

Peek.02-02-2024.08-12.mp4

Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@skjnldsv
Copy link
Member Author

skjnldsv commented Feb 7, 2024

/compile rebase /

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 7, 2024
Signed-off-by: nextcloud-command <[email protected]>
@nextcloud-command nextcloud-command force-pushed the fix/files/selection-typing-and-drop-upload branch from 95c0a90 to 5f4a0d9 Compare February 7, 2024 07:59
@skjnldsv
Copy link
Member Author

skjnldsv commented Feb 7, 2024

/backport to stable28

@skjnldsv skjnldsv merged commit 840e8fc into master Feb 7, 2024
85 checks passed
@skjnldsv skjnldsv deleted the fix/files/selection-typing-and-drop-upload branch February 7, 2024 08:53
@blizzz blizzz mentioned this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish feature: files regression technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants