fix(db): Let dirty writes cool off #43297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristophWurst
requested review from
nickvergessen,
juliushaertl and
sorbaugh
10 tasks
juliushaertl
approved these changes
Feb 16, 2024
ChristophWurst
force-pushed
the
fix/db/dirty-read-cool-off
branch
2 times, most recently
from
b13d328
to
1c6d07f
Compare
We can assume that after a few seconds a read will be clean again. This is helpful for false warnings in long running processes. Signed-off-by: Christoph Wurst <[email protected]>
ChristophWurst
force-pushed
the
fix/db/dirty-read-cool-off
branch
from
1c6d07f
to
1f46e4b
Compare
nickvergessen
approved these changes
Feb 19, 2024
ChristophWurst
added
4. to release
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We can assume that after a few seconds a read will be clean again. This is helpful for false warnings in long running processes.
TODO
Checklist