-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Migrate LinkReferenceProvider to OCP #43355
Conversation
It could've been an abstract class in OCP but that would interfere with |
a3a84cb
to
eee7c0e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment.
Then 👍 💙
c6629c8
to
4996970
Compare
|
there are a lot of changed hashes in the apps. Should that be included in the commit? apps/admin_audit/composer/composer/installed.php
- 'reference' => 'b1797842784b250fb01ed5e3bf130705eb94751b',
+ 'reference' => '49969705de01aff43cf2e6b662e5c96bd48a3b27', |
Just the ones updating the class paths should be enough I think |
This would be useful to eleminate the need for using this OC class when an app dev wants to implement a custom reference provider for the web client but wants to fall back on opengraph for mobile clients. Signed-off-by: Anupam Kumar <[email protected]>
4996970
to
7329b83
Compare
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
Summary
This would be useful to eleminate the need for using this OC class
when an app dev wants to implement a custom reference provider
for the web client but wants to fall back on opengraph for mobile
clients.
Checklist