perf(dashboard): Stop loading the viewer on the dashboard

[susnux]

Summary

Viewer is ~4MB of JS assets for loading, this is not needed on the dashboard and the sidebar is also not used on the dashboard - there is no sidebar at all.

before	after

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[ShGKme]

BTW, should it be considered a breaking change?

For example, if some community app uses dashboard api v1 and Viewer

[susnux]

@AndyScherzinger when emulating "fast 3G"-network connection on chrome the improvements are quite nice:

If you start on the login page with an empty cache the loading time for the first page (dashboard) is reduced by 44%:

before	after

[nickvergessen]

BTW, should it be considered a breaking change?
For example, if some community app uses dashboard api v1 and Viewer

I would say mentioning it in the developer docs doesn't hurt. The fix is also easy (emit the event yourself)

[skjnldsv]

I would say mentioning it in the developer docs doesn't hurt. The fix is also easy (emit the event yourself)

Which is also not really a fix, they should have done that since the beginning.
never rely on others triggering events for you :)

[susnux]

Documentation: nextcloud/documentation#11513