use lazy user in UserMountCache for getting user for cached mount instead of duplicating logic #43437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
force-pushed
the
cleanup-mount-by-id-duplication
branch
from
0d967eb
to
5125c00
Compare
icewind1991
requested review from
juliushaertl,
Altahrim,
a team,
ArtificialOwl and
Fenn-CS
and removed request for
a team
icewind1991
force-pushed
the
cleanup-mount-by-id-duplication
branch
from
5125c00
to
3ca220d
Compare
juliushaertl
approved these changes
Feb 14, 2024
icewind1991
force-pushed
the
cleanup-mount-by-id-duplication
branch
from
3ca220d
to
d3a7d6a
Compare
Signed-off-by: Robin Appelman <[email protected]>
This reverts commit 1e2cf82. Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
icewind1991
force-pushed
the
cleanup-mount-by-id-duplication
branch
from
d3a7d6a
to
51019fd
Compare
artonge
approved these changes
Mar 6, 2024
artonge
reviewed
Mar 6, 2024
| return null; | ||
| } | ||
| private function dbRowToMountInfo(array $row, ?callable $pathCallback = null): ICachedMountInfo { | ||
| $user = new LazyUser($row['user_id'], $this->userManager); |
There was a problem hiding this comment.
Maybe add a comment explaining the hack?
This is to prevent fetching the full user multiple times?
There was a problem hiding this comment.
fetching multiple times is not the issue (it's cached), it not having to fetch the user details when nobody is asking for it.
It's the same as with any other use of LazyUser so a comment would be redundant imo
come-nc
approved these changes
Mar 6, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove some duplication and hopefully make it clearer what the logic is doing
soft requires only get the path for the users cached mount info when we use it #43426 as they change the same type signature
reverts Filter mounts for file id before trying to get user information #26593 and uses
LazyUserinstead to achieve the same optimization