fix!: Remove deprecated RegisterWidgetEvent
#43439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
force-pushed
the
fix/remove-deprecated-event
branch
from
7ad34b8
to
634ef67
Compare
susnux
requested review from
nickvergessen,
ChristophWurst,
juliushaertl and
ShGKme
ChristophWurst
approved these changes
Feb 7, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
apps/weather_status/lib/Listeners/BeforeTemplateRenderedListener.php
Fixed
Show resolved
Hide resolved
nickvergessen
approved these changes
Feb 8, 2024
juliushaertl
approved these changes
Feb 8, 2024
Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
fix/remove-deprecated-event
branch
from
634ef67
to
a37b6c7
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The event was deprecated with Nextcloud 20 (4 years ago) and just used for Nextcloud 19 compatibility.
But the event handler itself was invalid as it is missing the second required parameter and thus never worked for at least 20 month.
It is not used anymore and the only place we used it was the weather status where it is now replaced.
Documentation PR: nextcloud/documentation#11515
Checklist