Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add block-unconventional-commits workflow #43444

Merged
merged 2 commits into from
Feb 26, 2024
Merged

feat: add block-unconventional-commits workflow #43444

merged 2 commits into from
Feb 26, 2024

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Feb 8, 2024

@nextcloud/server

@skjnldsv skjnldsv added the 3. to review Waiting for reviews label Feb 8, 2024
@skjnldsv skjnldsv requested a review from a team February 8, 2024 10:03
@skjnldsv skjnldsv self-assigned this Feb 8, 2024
emoral435
emoral435 approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@emoral435 emoral435 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can both agree, something about conventional commits are sexy 😍
LGTM 🐘

@emoral435 emoral435 mentioned this pull request Feb 8, 2024
Closed
@skjnldsv skjnldsv requested review from a team, Fenn-CS, szaimen, sorbaugh and ArtificialOwl and removed request for a team February 9, 2024 08:02
come-nc
come-nc reviewed Feb 12, 2024
View reviewed changes
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be accompanied with a documentation update, maybe here:
https://github.com/nextcloud/server/blob/master/.github/CONTRIBUTING.md
Or/and here:
https://docs.nextcloud.com/server/latest/developer_manual/getting_started/codingguidelines.html

@skjnldsv
Copy link
Member Author

Done @come-nc

@skjnldsv skjnldsv merged commit 663ecd9 into master Feb 26, 2024
160 checks passed
@skjnldsv skjnldsv deleted the skjnldsv-patch-1 branch February 26, 2024 11:15
@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@come-nc come-nc come-nc approved these changes

@emoral435 emoral435 emoral435 approved these changes

@Fenn-CS Fenn-CS Awaiting requested review from Fenn-CS Fenn-CS was automatically assigned from nextcloud/server-frontend

@szaimen szaimen Awaiting requested review from szaimen szaimen was automatically assigned from nextcloud/server-frontend

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh was automatically assigned from nextcloud/server-frontend

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl was automatically assigned from nextcloud/server-backend

Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skjnldsv @come-nc @emoral435