Cleanup cron.php method calls

[come-nc]

Summary

Cleanup cron.php and bring it to the modern world. Added strict_types as well.

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[solracsf]

Doesn't this need an adjustement?

server/lib/public/BackgroundJob/IJob.php

Lines 49 to 58 in 3b77df9

	/**
	* Run the background job with the registered argument
	*
	* @param IJobList $jobList The job list that manages the state of this job
	* @param ILogger|null $logger
	* @since 7.0.0
	* @deprecated since 25.0.0 Use start() instead. This method will be removed
	* with the ILogger interface
	*/
	public function execute(IJobList $jobList, ILogger $logger = null);

[come-nc]

Doesn't this need an adjustement?

server/lib/public/BackgroundJob/IJob.php

Lines 49 to 58 in 3b77df9

	/**
	* Run the background job with the registered argument
	*
	* @param IJobList $jobList The job list that manages the state of this job
	* @param ILogger|null $logger
	* @since 7.0.0
	* @deprecated since 25.0.0 Use start() instead. This method will be removed
	* with the ILogger interface
	*/
	public function execute(IJobList $jobList, ILogger $logger = null);

No, why?
The method was already deprecated as you see in the lines you linked to.
It will be removed along with ILogger class, I do not think it’s useful to remove it before.

[solracsf]

Because it espects ILogger and we're now passing LoggerInterface.

The method was already deprecated as you see in the lines you linked to.

Fine :)

[come-nc]

Because it espects ILogger and we're now passing LoggerInterface.

No we’re not, where?
Psalm would complain about it if we did I think.

Also I tried to remove all calls to execute, if you find some please list them.

[solracsf]

I've saw it somewhere in PSALM for another PR... 🤔
But if PSALM is happy now, i'm hapy too :)