Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sharing): Move video verification option to password and hide without Talk #43519

Merged
merged 2 commits into from
Feb 13, 2024

Conversation

nickvergessen
Copy link
Member

TODO

  • Move it right below the password option which makes it visible
  • Hide when Talk is not enabled

Checklist

// Anything else should be fine
return true
// Is Talk enabled?
return OC.appswebroots.spreed !== undefined
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same logic as 26:

},
/**
* Is Talk enabled?
*
* @return {boolean}
*/
isTalkEnabled() {
return OC.appswebroots.spreed !== undefined
},

@AndyScherzinger
Copy link
Member

AndyScherzinger commented Feb 12, 2024

/backport fa4b327 to stable28

@AndyScherzinger
Copy link
Member

AndyScherzinger commented Feb 12, 2024

/backport fa4b327 to stable27

Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with Talk app enabled/disabled

@nickvergessen nickvergessen merged commit 922de6e into master Feb 13, 2024
94 checks passed
@nickvergessen nickvergessen deleted the bugfix/41244/improve-video-verification-option branch February 13, 2024 10:05
@blizzz blizzz mentioned this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants