Add tests for versions actions #43768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artonge
force-pushed
the
artonge/tests/add_tests_for_versions_actions
branch
from
8833278
to
c122250
Compare
artonge
added
feature: versions
tests
artonge
force-pushed
the
artonge/tests/add_tests_for_versions_actions
branch
4 times, most recently
from
bf9d05e
to
6e4b010
Compare
artonge
added
3. to review
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
artonge
force-pushed
the
artonge/tests/add_tests_for_versions_actions
branch
3 times, most recently
from
5c4add8
to
6870c67
Compare
Signed-off-by: Louis Chemineau <[email protected]>
Signed-off-by: Louis Chemineau <[email protected]>
Signed-off-by: Louis Chemineau <[email protected]>
…em in from one of its actions Signed-off-by: Louis Chemineau <[email protected]>
Signed-off-by: Louis Chemineau <[email protected]>
Signed-off-by: Louis Chemineau <[email protected]>
Signed-off-by: Louis Chemineau <[email protected]>
Signed-off-by: Louis Chemineau <[email protected]>
Signed-off-by: Louis Chemineau <[email protected]>
artonge
force-pushed
the
artonge/tests/add_tests_for_versions_actions
branch
from
6870c67
to
f7a0246
Compare
|
/backport 5137757 to stable28 |
|
/backport 5137757 to stable27 |
|
/backport 5137757 to stable26 |
|
/backport 5137757 to stable25 |
skjnldsv
reviewed
Feb 27, 2024
Comment on lines
+274
to
+278
| async deleteVersion() { | ||
| // Let @nc-vue properly remove the popover before we delete the version. | ||
| // This prevents @nc-vue from throwing a error. | ||
| await this.$nextTick() | ||
| await this.$nextTick() |
There was a problem hiding this comment.
I feel like we could have something better here 🤔
There was a problem hiding this comment.
I guess we should prevent the property access in @nc/vue, but I was too lazy.
skjnldsv
requested review from
a team,
szaimen,
sorbaugh and
emoral435
and removed request for
a team
susnux
approved these changes
Feb 27, 2024
Seconded, didn't we talked about this 🙈 |
This was referenced Feb 27, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR initial goal was to tests that permissions were properly checked when triggering versions actions on received shared files. But I wrote some tests utils on the way, and encountered a few bugs.
Tests changes
files_sharingfilesfiles_sharingandfiles_versionscomponentsCode changes
Version.vuefrom@nc/vuewhen deleting anNcListItemfrom one of its actionsViewOnlyPluginafter auth to prevent error when using Basic auth