Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added new action for qrcode popup on link-share actions #43774

Merged
merged 4 commits into from
Mar 6, 2024
Merged

feat: added new action for qrcode popup on link-share actions #43774

merged 4 commits into from
Mar 6, 2024

Conversation

emoral435
Copy link
Contributor

@emoral435 emoral435 commented Feb 22, 2024 •
edited
Loading

  • Resolves nextcloud-gmbh/customer-feature-requests#702

Summary

  • We somehow already had a QR code library in the main server repository... dunno where it is used, though! Weird, but using that, I generated an img element with the corresponding link-shares URL encoded into the QR code. Check it out for yourself, its pretty cool!
  • QR Code uses the same link as the regular link share uses

Feature Visuals

Desktop
firefox_gfjbcwEO3X
Mobile
firefox_A8ekVZM0lH

Checklist

@emoral435 emoral435 force-pushed the feat/spring2024/add-qr-code-for-link-share branch from 15e55b7 to d45c025 Compare February 24, 2024 01:49
@github-actions GitHub Actions
Copy link
Contributor

Possible performance regression detected

Show Output 
564 queries added

= /remote.php/dav/files/test
= /remote.php/dav/files/test/test.txt
= /remote.php/dav/files/test/many_files
= /remote.php/dav/files/test/new_file.txt
= /remote.php/dav/files/test/new_file.txt
= /remote.php/dav/files/test
= /remote.php/dav/files/test/test.txt
= /remote.php/dav/files/test/many_files
= /remote.php/dav/files/test/new_file.txt
= /remote.php/dav/files/test/new_file.txt
+ /remote.php/dav/files/test added with 45 queries
+ /remote.php/dav/files/test/test.txt added with 33 queries
+ /remote.php/dav/files/test/many_files added with 46 queries
+ /remote.php/dav/files/test/new_file.txt added with 67 queries
+ /remote.php/dav/files/test/new_file.txt added with 91 queries
+ /remote.php/dav/files/test added with 45 queries
+ /remote.php/dav/files/test/test.txt added with 33 queries
+ /remote.php/dav/files/test/many_files added with 46 queries
+ /remote.php/dav/files/test/new_file.txt added with 67 queries
+ /remote.php/dav/files/test/new_file.txt added with 91 queries

@emoral435 emoral435 self-assigned this Feb 26, 2024
@emoral435 emoral435 added the 3. to review Waiting for reviews label Feb 26, 2024
@emoral435 emoral435 added this to the Nextcloud 29 milestone Feb 26, 2024
@emoral435 emoral435 force-pushed the feat/spring2024/add-qr-code-for-link-share branch from d45c025 to ea8b41e Compare February 26, 2024 14:10
@emoral435 emoral435 marked this pull request as ready for review February 26, 2024 14:13
@emoral435 emoral435 force-pushed the feat/spring2024/add-qr-code-for-link-share branch from ea8b41e to 43132d3 Compare February 26, 2024 20:24
@emoral435

This comment was marked as resolved.

Sign in to view
@emoral435 emoral435 force-pushed the feat/spring2024/add-qr-code-for-link-share branch 2 times, most recently from 60429ef to 541bdc1 Compare February 26, 2024 20:33
@emoral435
Copy link
Contributor Author

Updated the icon for clipboard as well, continuing off @susnux 's recommendation to clean up some of the icon usage :)

Screenshot:
image

@emoral435 emoral435 force-pushed the feat/spring2024/add-qr-code-for-link-share branch from 541bdc1 to 07b98d0 Compare February 28, 2024 03:19
susnux
susnux reviewed Feb 28, 2024
View reviewed changes
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the icon changes!
Added some comments

@emoral435 emoral435 force-pushed the feat/spring2024/add-qr-code-for-link-share branch 2 times, most recently from 19438c1 to d843466 Compare February 28, 2024 15:04
@emoral435
Copy link
Contributor Author

Resolved all comments :)

susnux
susnux approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you!

ShGKme
ShGKme approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good code-wise, but haven't tested with the latest changes.

@emoral435 emoral435 force-pushed the feat/spring2024/add-qr-code-for-link-share branch from d843466 to e0e17d5 Compare March 1, 2024 19:47
@emoral435 emoral435 enabled auto-merge March 1, 2024 19:47
@emoral435 emoral435 force-pushed the feat/spring2024/add-qr-code-for-link-share branch 4 times, most recently from c6f49a1 to 306cebe Compare March 6, 2024 13:09
@sorbaugh sorbaugh mentioned this pull request Mar 6, 2024
Merged
@emoral435 emoral435 force-pushed the feat/spring2024/add-qr-code-for-link-share branch 2 times, most recently from 1f4b0a9 to 56cfdda Compare March 6, 2024 14:45
@skjnldsv
Copy link
Member

skjnldsv commented Mar 6, 2024

I'll rebase and force merge, everything is green otherwise

@skjnldsv skjnldsv disabled auto-merge March 6, 2024 17:42
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 6, 2024
@emoral435 @skjnldsv
chore: compile assets
96e7e9f 
Signed-off-by: Eduardo Morales <[email protected]>
@skjnldsv skjnldsv force-pushed the feat/spring2024/add-qr-code-for-link-share branch from 56cfdda to 96e7e9f Compare March 6, 2024 17:45
@skjnldsv skjnldsv merged commit b3a2bb8 into master Mar 6, 2024
34 of 36 checks passed
@skjnldsv skjnldsv deleted the feat/spring2024/add-qr-code-for-link-share branch March 6, 2024 17:45
@Fenn-CS Fenn-CS mentioned this pull request Jun 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@ShGKme ShGKme ShGKme approved these changes

@Fenn-CS Fenn-CS Awaiting requested review from Fenn-CS

@Pytal Pytal Awaiting requested review from Pytal

@skjnldsv skjnldsv Awaiting requested review from skjnldsv skjnldsv is a code owner

Assignees

@emoral435 emoral435

Labels
4. to release Ready to be released and/or waiting for tests to finish feature: files feature: sharing 🍀 2024-Spring
Projects
📁 Files team
Archived in project
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.
5 participants
@emoral435 @skjnldsv @susnux @ShGKme @AndyScherzinger