Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle more cases in the MergeDistributive search query optimizer #43975

Merged
merged 3 commits into from
Mar 5, 2024

Conversation

icewind1991
Copy link
Member

If an AND/OR operator contains more than just AND/OR arguments it was previously skipped. Now those parts are factored out properly and the rest is still optimized.

@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Mar 4, 2024
@icewind1991 icewind1991 added this to the Nextcloud 29 milestone Mar 4, 2024
@icewind1991 icewind1991 requested review from a team, ArtificialOwl, Fenn-CS, sorbaugh and starypatyk and removed request for a team March 4, 2024 10:45
Copy link
Contributor

@starypatyk starypatyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Thanks @icewind1991 !

Copy link
Contributor

@emoral435 emoral435 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For context, I am no expert with the backend for server, but this LGTM :)

@icewind1991 icewind1991 merged commit 56c75aa into master Mar 5, 2024
160 checks passed
@icewind1991 icewind1991 deleted the search-optimize-fixes branch March 5, 2024 09:26
@blizzz blizzz mentioned this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants