Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(settings): Disable app again if it breaks the files app #44016

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Mar 5, 2024

Summary

Apps can no longer hard break the server core, see also #44014 , but they still might break the files app.
This is and was tested, but it only set on the UI.

So if it fails it now also:

  1. Show an visible error toast
  2. Disable the app again

Checklist

@susnux susnux requested review from artonge, a team, Fenn-CS, szaimen, Pytal and come-nc and removed request for a team March 5, 2024 23:36
@susnux susnux added this to the Nextcloud 29 milestone Mar 5, 2024
@susnux
Copy link
Contributor Author

susnux commented Mar 6, 2024

/backport to stable28

@Pytal Pytal merged commit 945d97d into master Mar 6, 2024
98 checks passed
@Pytal Pytal deleted the fix/disable-app-again-if-failed branch March 6, 2024 09:39
@blizzz blizzz mentioned this pull request Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants