fix(user_ldap): Early failure for empty password login attempt #44042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids user_ldap logging about an invalid configuration with an empty password when the empty password actually comes from a login attempt. Signed-off-by: Côme Chilliet <[email protected]>
|
/backport to stable28 |
|
/backport to stable27 |
|
/backport to stable26 |
come-nc
requested review from
blizzz,
a team,
icewind1991,
Fenn-CS and
sorbaugh
and removed request for
a team
icewind1991
approved these changes
Mar 6, 2024
Fenn-CS
approved these changes
Mar 6, 2024
come-nc
deleted the
fix/fix-erronous-log-on-login-attempt-with-no-password
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This avoids user_ldap logging about an invalid configuration with an
empty password when the empty password actually comes from a login
attempt.
Checklist