[stable25] Forbid tagging readonly files #44309
Conversation
![backportbot[bot]](https://avatars.githubusercontent.com/in/60201?s=60&v=4){kind=small}
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
come-nc
force-pushed
the
backport/44299/stable25
branch
from
bcddd21
to
4016c22
Compare
come-nc
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -60,10 +60,19 @@ | |||
| $tagMapper, | |||
| $userSession, | |||
| $groupManager, | |||
| function ($name) { | |||
| function ($name): bool { | |||
Check notice
Code scanning / Psalm
MissingClosureParamType Note
| $nodes = \OC::$server->getUserFolder()->getById((int)$name); | ||
| return !empty($nodes); | ||
| } | ||
| }, | ||
| function ($name): bool { |
Check notice
Code scanning / Psalm
MissingClosureParamType Note
| } | ||
| }, | ||
| function ($name): bool { | ||
| $nodes = \OC::$server->getUserFolder()->getById((int)$name); |
Check notice
Code scanning / Psalm
DeprecatedMethod Note
| } | ||
| }, | ||
| function ($name): bool { | ||
| $nodes = \OC::$server->getUserFolder()->getById((int)$name); |
Check notice
Code scanning / Psalm
PossiblyNullReference Note
| @@ -77,7 +86,8 @@ | |||
| $tagMapper, | |||
| $userSession, | |||
| $groupManager, | |||
| $entityExistsFunction | |||
| $entityExistsFunction, | |||
| fn ($name) => true, | |||
Check notice
Code scanning / Psalm
MissingClosureParamType Note
25 supports 7.4 Signed-off-by: Côme Chilliet <[email protected]>
come-nc
force-pushed
the
backport/44299/stable25
branch
from
4016c22
to
43865ac
Compare
|
/backport! to stable24 |
|
/backport! to stable23 |
|
Can someone restart drone job? Failures are weird. |
come-nc
added
4. to release
|
All good. Needs a force merge because 25 is EOL |
Backport of #44299 / #44297
Warning, This backport's changes differ from the original and might be incomplete⚠️ Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.