Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add interface for lower level filecache acess without having to do direct db queries #44458

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

icewind1991
Copy link
Member

Adds and interface for the filecache that is lower level than the "normal" filesystem apis to allow for some more optimized retrieval of filecache data without requiring direct database access.

This will be needed when we start restricting direct database access to the filecache for sharding.

Split from #44044

@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Mar 25, 2024
@icewind1991 icewind1991 added this to the Nextcloud 29 milestone Mar 25, 2024
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

lib/private/Files/Cache/FileAccess.php Show resolved Hide resolved
lib/private/Files/Cache/FileAccess.php Outdated Show resolved Hide resolved
lib/private/Files/Cache/FileAccess.php Outdated Show resolved Hide resolved
lib/private/Files/Cache/FileAccess.php Outdated Show resolved Hide resolved
lib/public/Files/Cache/IFileAccess.php Show resolved Hide resolved
lib/public/Files/Cache/IFileAccess.php Outdated Show resolved Hide resolved
lib/public/Files/Cache/IFileAccess.php Outdated Show resolved Hide resolved
lib/public/Files/Cache/IFileAccess.php Outdated Show resolved Hide resolved
@icewind1991 icewind1991 merged commit ae19e94 into master Mar 25, 2024
167 checks passed
@icewind1991 icewind1991 deleted the fileacces-interface branch March 25, 2024 16:28
@Altahrim Altahrim mentioned this pull request Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants