Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable29] fix(sharingDetails): Show correct share target #44918

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Apr 18, 2024

Backport of #44839

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot added 3. to review Waiting for reviews feature: sharing labels Apr 18, 2024
@backportbot backportbot bot added this to the Nextcloud 29 milestone Apr 18, 2024
The share details page should show the target email or user/server to which

the user is creating the share.

Signed-off-by: fenn-cs <[email protected]>

[skip ci]
@Fenn-CS
Copy link
Contributor

Fenn-CS commented Apr 19, 2024

/compile

@Fenn-CS Fenn-CS marked this pull request as ready for review April 19, 2024 10:21
@Fenn-CS
Copy link
Contributor

Fenn-CS commented Apr 19, 2024

/backport to stable28

Signed-off-by: nextcloud-command <[email protected]>
@Altahrim Altahrim mentioned this pull request Apr 23, 2024
25 tasks
@Fenn-CS Fenn-CS merged commit eb58f8e into stable29 Apr 25, 2024
105 checks passed
@Fenn-CS Fenn-CS deleted the backport/44839/stable29 branch April 25, 2024 06:06
Copy link
Author

backportbot bot commented Apr 25, 2024

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b backport/44918/stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 5ed47da2 547d5845

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/44918/stable28

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@Fenn-CS
Copy link
Contributor

Fenn-CS commented Apr 25, 2024

/backport to stable28

Copy link
Author

backportbot bot commented Apr 25, 2024

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b backport/44918/stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 5ed47da2 547d5845

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/44918/stable28

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants