Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:Ensure security.txt file ends with a newline character #45508

Merged
merged 1 commit into from
May 29, 2024

Conversation

Agnibaan
Copy link
Contributor

@Agnibaan Agnibaan commented May 25, 2024

Summary

This commit addresses issue #42611 by ensuring that the generated security.txt file consistently ends with a newline character. This change aligns the file with the recommended best practices outlined in RFC 9116.

Additionally, the commit updates the relevant unit test to verify that the newline character is correctly added.

TODO

  • ...

before
image

after
image

Checklist

@Agnibaan
Copy link
Contributor Author

@skjnldsv @Pytal Hey can u guys review this request....

@joshtrichards joshtrichards added 3. to review Waiting for reviews bug labels May 26, 2024
@joshtrichards joshtrichards added this to the Nextcloud 30 milestone May 26, 2024
@Agnibaan
Copy link
Contributor Author

hey @joshtrichards can u tell me what's wrong in my commit , i couldn't understand it..

Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Cypress CI will not work on forked repositories, so this is expected to be red

@susnux susnux requested a review from come-nc May 29, 2024 13:37
@skjnldsv skjnldsv merged commit a5fd623 into nextcloud:master May 29, 2024
147 of 154 checks passed
Copy link

welcome bot commented May 29, 2024

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

Copy link
Contributor

github-actions bot commented Jun 9, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

security.txt should end with a newline
4 participants