Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: delay getting (sub)admin status for user in the security middleware untill we need it #46021

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

icewind1991
Copy link
Member

@icewind1991 icewind1991 commented Jun 20, 2024

No need to check if we're admin for non-admin routes.

Should save 1 or 2 queries for most routes

@icewind1991 icewind1991 added this to the Nextcloud 30 milestone Jun 20, 2024
@icewind1991 icewind1991 requested review from nickvergessen, a team, ArtificialOwl, yemkareems and sorbaugh and removed request for a team June 20, 2024 16:46
@susnux
Copy link
Contributor

susnux commented Jul 9, 2024

Conflicting files
tests/lib/AppFramework/Middleware/Security/SecurityMiddlewareTest.php

This was referenced Jul 30, 2024
This was referenced Aug 5, 2024
@skjnldsv skjnldsv mentioned this pull request Aug 13, 2024
@skjnldsv skjnldsv modified the milestones: Nextcloud 30, Nextcloud 31 Aug 14, 2024
@icewind1991 icewind1991 merged commit 4a3ade5 into master Aug 23, 2024
172 checks passed
@icewind1991 icewind1991 deleted the middleware-delay-admin branch August 23, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants