Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(files): Prevent extraneous requests when tree children are loading #47157

Merged
merged 2 commits into from
Aug 10, 2024
Merged

perf(files): Prevent extraneous requests when tree children are loading #47157

merged 2 commits into from
Aug 10, 2024

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Aug 9, 2024

Summary

  • Prevents identical requests if the children are already loading

Checklist

@Pytal Pytal added this to the Nextcloud 30 milestone Aug 9, 2024
@Pytal Pytal requested a review from a team August 9, 2024 22:38
@Pytal Pytal self-assigned this Aug 9, 2024
@Pytal Pytal requested a review from skjnldsv as a code owner August 9, 2024 22:38
@Pytal Pytal requested review from Fenn-CS and szaimen and removed request for a team August 9, 2024 22:38
@Pytal Pytal enabled auto-merge August 9, 2024 22:38
@Pytal Pytal merged commit 4a512d4 into master Aug 10, 2024
111 checks passed
@Pytal Pytal deleted the perf/prevent-extra-requests branch August 10, 2024 12:59
@skjnldsv skjnldsv mentioned this pull request Aug 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@Fenn-CS Fenn-CS Awaiting requested review from Fenn-CS Fenn-CS was automatically assigned from nextcloud/server-frontend

@szaimen szaimen Awaiting requested review from szaimen szaimen was automatically assigned from nextcloud/server-frontend

Assignees

@Pytal Pytal

Labels
3. to review Waiting for reviews bug feature: files performance 🚀
Projects
None yet
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.
3 participants
@Pytal @susnux @skjnldsv