Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable30] feat(share): ensure unique share tokens #48142

Merged
merged 1 commit into from
Sep 26, 2024
Merged

[stable30] feat(share): ensure unique share tokens #48142

merged 1 commit into from
Sep 26, 2024

Conversation

nickvergessen
Copy link
Member

  • check for token collisions and retry up to three times.
  • abort with an error if maximum token length is reached without finding a unique token.

Backport of #47265

Checklist

@nickvergessen nickvergessen added this to the Nextcloud 30.0.1 milestone Sep 17, 2024
@nickvergessen nickvergessen self-assigned this Sep 17, 2024
@nickvergessen
Copy link
Member Author

/backport to stable29

@nickvergessen
Copy link
Member Author

/backport to stable28

@nickvergessen
Copy link
Member Author

/backport to stable28

@nickvergessen
Copy link
Member Author

/backport to stable27

@nickvergessen
Copy link
Member Author

/backport to stable26

@nickvergessen
Copy link
Member Author

/backport to stable25

github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 17, 2024
View reviewed changes
lib/private/Share20/Manager.php Fixed Show resolved Hide resolved
@ernolf @nickvergessen
fix(share): Ensure unique share tokens
0551919 
- check for token collisions and retry up to three times.
- throw after 3 attempts without finding a unique token.

Signed-off-by: ernolf <[email protected]>
ernolf
ernolf approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@ernolf ernolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works!

@nickvergessen nickvergessen requested review from a team, ArtificialOwl, yemkareems and come-nc and removed request for a team September 25, 2024 10:05
@nickvergessen nickvergessen merged commit 5cc1fb9 into stable30 Sep 26, 2024
172 checks passed
@nickvergessen nickvergessen deleted the backport/47265/stable30 branch September 26, 2024 10:33
@nickvergessen nickvergessen changed the title [stable30] feat(share): ensure unique share tokens with dynamic length adjustment [stable30] feat(share): ensure unique share tokens Sep 26, 2024
This was referenced Sep 26, 2024
Merged
Merged
Merged
This was referenced Sep 26, 2024
Merged
Merged
@Altahrim Altahrim mentioned this pull request Oct 1, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ernolf ernolf ernolf approved these changes

@come-nc come-nc come-nc approved these changes

@juliushaertl juliushaertl Awaiting requested review from juliushaertl

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl was automatically assigned from nextcloud/server-backend

@yemkareems yemkareems Awaiting requested review from yemkareems yemkareems was automatically assigned from nextcloud/server-backend

Assignees

@nickvergessen nickvergessen

Labels
3. to review Waiting for reviews bug feature: sharing
Projects
None yet
Milestone
Nextcloud 30.0.1
Development

Successfully merging this pull request may close these issues.
3 participants
@nickvergessen @ernolf @come-nc