fix: Vue app names #48536
Open
fix: Vue app names #48536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
approved these changes
Oct 2, 2024
Pytal
approved these changes
Oct 2, 2024
This improves the debugging experience in the vue dev tool. Signed-off-by: Louis Chemineau <[email protected]>
Signed-off-by: Louis Chemineau <[email protected]>
Signed-off-by: Louis Chemineau <[email protected]>
artonge
force-pushed
the
artonge/fix/vue_app_names
branch
from
d95679d
to
44eadf2
Compare
Pytal
reviewed
Oct 3, 2024
| import axios from '@nextcloud/axios' | ||
| import moment from '@nextcloud/moment' |
There was a problem hiding this comment.
We should move away from moment, no?
There was a problem hiding this comment.
We can already use useFormatDateTime from nc/vue but can be done in followup too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NcSelectinNcSharingInputNcListIteminVersion. Will need usage ofactions-aria-label(https://github.com/nextcloud-libraries/nextcloud-vue/pull/6128/files)