-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate ID columns to bigint #6563
Conversation
@nickvergessen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @rullzer, @MorrisJobke and @LukasReschke to be potential reviewers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine by me
Codecov Report
@@ Coverage Diff @@
## master #6563 +/- ##
============================================
+ Coverage 53.06% 56.25% +3.19%
============================================
Files 1417 61 -1356
Lines 87809 7574 -80235
Branches 1340 1340
============================================
- Hits 46596 4261 -42335
+ Misses 41213 3313 -37900 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge conflict
4df2a51
to
58b307f
Compare
Rebased, ready for review and merge |
4ef49be
to
beea34b
Compare
@LukasReschke please review, so this is available early in dailies and master for testing |
/** | ||
* Auto-generated migration step: Please modify to your needs! | ||
*/ | ||
class Version1004Date20170919103422 extends BigIntMigration { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is not executed at all. :/
My migrations table for dav looks like this:
dav | 1004Date20170825134824
dav | 1004Date20170919104507
dav | 1004Date20170924124212
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I bet that is ebcause we merged the other migration to dav.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah need to rebase and change the timestamp to be newer...
#JustDevProblems....
Will have a look separate if we can detect not executed migrations and run them individually
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will have a look separate if we can detect not executed migrations and run them individually
isn't that the idea of migrations? xD I thought it will just be checked what was already done and what not and then execute all not executed ones.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No the issue is you need to do it sequentially. So you can't just insert a new one in the middle. Because that could lead to inconsistencies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exactly, I would also only allow this for debug,...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay actually it should have worked, the problem is another PR bumped the version number for the dav app on master already, therefor no update was done at all.
Fixed it now.
53d0734
to
4243f40
Compare
return [ | ||
'addressbooks' => ['id'], | ||
'addressbookchanges' => ['id', 'addressbookid'], | ||
'calendars' => ['id', 'calendarid'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doctrine\DBAL\Schema\SchemaException: There is no column with name 'calendarid' on table 'oc_calendars'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stupid copy and paste, but I checked the dav tables and it looks good now.
Codecov Report
@@ Coverage Diff @@
## master #6563 +/- ##
============================================
- Coverage 53.03% 53.01% -0.02%
- Complexity 22583 22606 +23
============================================
Files 1417 1422 +5
Lines 87873 87954 +81
Branches 1341 1341
============================================
+ Hits 46601 46629 +28
- Misses 41272 41325 +53
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works 👍
I also fixed the autoloader. |
What, postgres fails?
|
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
dcea970
to
f205412
Compare
Copied owncloud/core#28364 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still working fine 👍
For better scaling