Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(federation): Don't remove federation rooms while waiting for accept/reject #10678

Merged
merged 3 commits into from
Oct 11, 2023
Merged

fix(federation): Don't remove federation rooms while waiting for accept/reject #10678

merged 3 commits into from
Oct 11, 2023

Conversation

nickvergessen
Copy link
Member

☑️ Resolves

🛠️ API Checklist

🚧 Tasks

  • Keep rooms if they have pending invites
  • Remove notifications when the invite or room got deleted
  • Remove unwanted exposure of internal exceptions that are not part of the API

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@nickvergessen nickvergessen added 3. to review feature: api 🛠️ OCS API for conversations, chats and participants feature: federation 🌐 labels Oct 11, 2023
@nickvergessen nickvergessen added this to the 💙 Next Major (28) milestone Oct 11, 2023
@nickvergessen nickvergessen self-assigned this Oct 11, 2023
@nickvergessen nickvergessen force-pushed the bugfix/5723/cron-job-removes-invited-rooms branch from e86fac3 to 8dae9a9 Compare October 11, 2023 05:38
@nickvergessen nickvergessen force-pushed the bugfix/5723/cron-job-removes-invited-rooms branch from 8dae9a9 to 22fb25a Compare October 11, 2023 05:42
@nickvergessen nickvergessen merged commit dc46119 into master Oct 11, 2023
51 checks passed
@nickvergessen nickvergessen deleted the bugfix/5723/cron-job-removes-invited-rooms branch October 11, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SystemKeeper SystemKeeper SystemKeeper approved these changes

Assignees

@nickvergessen nickvergessen

Labels
3. to review feature: api 🛠️ OCS API for conversations, chats and participants feature: federation 🌐
Projects
None yet
Milestone
v18.0.0-beta.1
Development

Successfully merging this pull request may close these issues.
2 participants
@nickvergessen @SystemKeeper