Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(OpenConversationsList): expose description #12243

Merged
merged 3 commits into from
May 4, 2024
Merged

feat(OpenConversationsList): expose description #12243

merged 3 commits into from
May 4, 2024

Conversation

DorraJaouad
Copy link
Contributor

@DorraJaouad DorraJaouad commented Apr 29, 2024 •
edited by nickvergessen
Loading

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image

🚧 Tasks

  • exposed description from backend
  • added exposeDescription injection and it has a priority over exposeMessage -> maybe the opposite is better ?
  • exposeMessage and exposeDescription are not needed to be reactive, simplified them to booleans
  • Adjust header styling

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • 🖥️ Tested with Desktop client or should not be risky for it
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

🛠️ API Checklist

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@DorraJaouad DorraJaouad added this to the 💙 Next Major (30) milestone Apr 29, 2024
@DorraJaouad DorraJaouad self-assigned this Apr 29, 2024
Antreesy
Antreesy reviewed Apr 29, 2024
View reviewed changes
src/App.vue Show resolved Hide resolved
src/components/LeftSidebar/ConversationsList/ConversationSearchResult.vue Outdated Show resolved Hide resolved
src/components/LeftSidebar/ConversationsList/Conversation.vue Outdated Show resolved Hide resolved
src/composables/useConversationInfo.js Outdated Show resolved Hide resolved
src/composables/useConversationInfo.js Outdated Show resolved Hide resolved
@nickvergessen
Copy link
Member

Added API test

@DorraJaouad DorraJaouad force-pushed the feat/12209/show-description branch 2 times, most recently from 776c66a to ecf8d36 Compare April 30, 2024 14:16
Antreesy
Antreesy approved these changes May 2, 2024
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, looks better now. Please check comments (for further improvement, maybe?)

src/components/LeftSidebar/ConversationsList/ConversationSearchResult.vue Outdated Show resolved Hide resolved
src/composables/useConversationInfo.js Outdated Show resolved Hide resolved
@DorraJaouad DorraJaouad force-pushed the feat/12209/show-description branch from ecf8d36 to f25ae56 Compare May 2, 2024 18:33
@DorraJaouad DorraJaouad force-pushed the feat/12209/show-description branch from 46dcbc5 to d52b580 Compare May 3, 2024 14:23
Antreesy
Antreesy approved these changes May 3, 2024
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, looks good!

src/composables/useConversationInfo.js Outdated Show resolved Hide resolved
@DorraJaouad DorraJaouad force-pushed the feat/12209/show-description branch from d52b580 to 3d65a1e Compare May 4, 2024 06:44
@DorraJaouad DorraJaouad force-pushed the feat/12209/show-description branch from 3d65a1e to 2a20afd Compare May 4, 2024 07:14
@DorraJaouad DorraJaouad merged commit 665327a into main May 4, 2024
64 checks passed
@DorraJaouad DorraJaouad deleted the feat/12209/show-description branch May 4, 2024 08:22
This was referenced May 6, 2024
Closed
Closed
@Antreesy Antreesy mentioned this pull request May 13, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen left review comments

@Antreesy Antreesy Antreesy approved these changes

Assignees

@DorraJaouad DorraJaouad

Labels
3. to review enhancement feature: conversations 👥
Projects
None yet
Milestone
v20.0.0-beta.1
Development

Successfully merging this pull request may close these issues.

Show description when listing open conversations
3 participants
@DorraJaouad @nickvergessen @Antreesy